[RFA] Change objfile to use new/delete

[Simon Marchi]

On 2017-10-12 02:19 PM, Tom Tromey wrote:
> This changes objfiles to use new and delete rather than xmalloc and
> free.  Simon noticed that it uses a non-POD and so shouldn't be
> allocated with XCNEW; and I wanted to be able to use another non-POD as
> a member; this patch is the result.
> 
> Regression tested by the buildbot.

This LGTM, just one formatting nit.

> @@ -277,11 +277,16 @@ struct objfile_per_bfd_storage
>  
>  struct objfile
>  {
> +  objfile (bfd *, const char *name, objfile_flags);

Let's try to be consistent in one prototype, either include the parameter
names or not.

Thanks,

Simon