[PATCH] Use std::vector for symtab_fns
Pedro Alves
palves@redhat.com
Wed Oct 11 13:05:00 GMT 2017
On 10/10/2017 09:01 PM, Simon Marchi wrote:
> Simple replacement of VEC with std::vector.
>
> gdb/ChangeLog:
>
> * symfile.c (registered_sym_fns): Make struct, not typedef.
> (DEF_VEC_O (registered_sym_fns)): Remove.
> (symtab_fns): Change type to std::vector.
> (add_symtab_fns): Adjust.
> (find_sym_fns): Adjust.
OK.
> - for (i = 0; VEC_iterate (registered_sym_fns, symtab_fns, i, rsf); ++i)
> - if (our_flavour == rsf->sym_flavour)
> - return rsf->sym_fns;
> + for (registered_sym_fns &rsf : symtab_fns)
Small nit: could this be a const ref? I think it's a good
rule to prefer const over non-const references if we can.
> + if (our_flavour == rsf.sym_flavour)
> + return rsf.sym_fns;
>
> error (_("I'm sorry, Dave, I can't do that. Symbol format `%s' unknown."),
> bfd_get_target (abfd));
>
Thanks,
Pedro Alves
More information about the Gdb-patches
mailing list