[RFC][08/19] Target FP: Use target format throughout expression parsing

[Simon Marchi]

On 2017-10-09 02:12 PM, Joel Brobecker wrote:
> One C++ thing I did notice but forgot to report...
> 
>> +floatformat_from_string (const struct floatformat *fmt, gdb_byte *out,
>> +			 std::string in)
> 
> Again, to be double-checked, but I think you want to pass the argument
> by reference in this case. Otherwise, you may end up having an overhead
> with might not be necessary due to the creation of a copy of the string
> being passed as argument here.
> 

Indeed, it's good practice to pass constant strings (or other objects) as
const references (const std::string &in).

Simon