[PATCH, gdb/testsuite] Fix wrong return type in tests

Thomas Preudhomme thomas.preudhomme@foss.arm.com
Wed Nov 29 13:43:00 GMT 2017


Done (see attached patch).

*** gdb/testsuite/ChangeLog ***

2017-11-29  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* gdb.cp/psymtab-parameter.cc (func): Change return type back to long.
	Return 0 as a long.
	* gdb.cp/psymtab-parameter.exp: Change func's return type back to long.

Testing: Testcase still PASSes with the change.

Best regards,

Thomas

On 29/11/17 12:06, Pedro Alves wrote:
> On 11/29/2017 11:59 AM, Thomas Preudhomme wrote:
>> My apologize, I thought it couldn't be significant since it was not
>> returning anything.  I didn't think about the impact on the prototype
>> itself.
> 
> No worries.  It was easy to miss.
> 
> How about making it return 0 instead then?
> 
> Yes please, go ahead and push such a fix in.
> 
> Thanks,
> Pedro Alves
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_return_type_psymtab-parameter.patch
Type: text/x-patch
Size: 1150 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20171129/d98140eb/attachment.bin>


More information about the Gdb-patches mailing list