[RFA 10/13] Simplify COMMON_OBS by using list of sources

Pedro Alves palves@redhat.com
Wed Nov 22 11:06:00 GMT 2017


On 11/21/2017 10:10 PM, Tom Tromey wrote:
>  # All source files that go into linking GDB.
>  # Links made at configuration time should not be specified here, since
> -# SFILES is used in building the distribution archive.
>  

The "(...) specified here, since" sentence looks cut in half after
this.

Otherwise looks good.

(I find COMMON_ vs gdb/common/ confusing, BTW, but that's
not your doing.)

> -SFILES = \
> -	ada-exp.y \
> +# Files that should wind up in SFILES and whose corresponding .o
> +# should be in COMMON_OBS.
> +COMMON_SFILES = \
>  	ada-lang.c \

...

>  	xml-syscall.c \
> -	xml-tdesc.c \
> +	xml-tdesc.c
> +
> +# SFILES is used in building the distribution archive.
> +SFILES = \
> +	ada-exp.y \
> +	arch/i386.c \
> +	ax-gdb.c \
>  
>  TSOBS = inflow.o

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list