[PATCH] [testsuite] Remove code setting target_cflags -D_MIT_POSIX_THREADS

Yao Qi qiyaoltc@gmail.com
Tue Nov 21 15:16:00 GMT 2017


target_cflags is not used at all.  This patch removes it.  I searched the
history of gdb, gcc and dejagnu, I don't see how target_cflags was used.

gdb/testsuite:

2017-11-21  Yao Qi  <yao.qi@linaro.org>

	* gdb.threads/gcore-thread.exp: Remove code setting
	target_cflags.
	* gdb.threads/pthreads.exp: Likewise.
	* gdb.threads/tls-nodebug.exp: Likewise.
	* gdb.threads/tls.exp: Likewise.
---
 gdb/testsuite/gdb.threads/gcore-thread.exp | 6 ------
 gdb/testsuite/gdb.threads/pthreads.exp     | 6 ------
 gdb/testsuite/gdb.threads/tls-nodebug.exp  | 6 ------
 gdb/testsuite/gdb.threads/tls.exp          | 6 ------
 4 files changed, 24 deletions(-)

diff --git a/gdb/testsuite/gdb.threads/gcore-thread.exp b/gdb/testsuite/gdb.threads/gcore-thread.exp
index b01fa83..571b25c 100644
--- a/gdb/testsuite/gdb.threads/gcore-thread.exp
+++ b/gdb/testsuite/gdb.threads/gcore-thread.exp
@@ -22,12 +22,6 @@ set objfile  $binfile.o
 set corefile $binfile.test
 set core0file ${binfile}0.test
 
-if [istarget "*-*-linux"] then {
-    set target_cflags "-D_MIT_POSIX_THREADS"
-} else {
-    set target_cflags ""
-}
-
 # Attempt to prevent -Wl,-z,relro which happens by default at least on
 # Kubuntu-10.10.  Due to PR corefiles/11804 will then GDB be unable to find
 # libpthread, therefore libthread_db will not fail as expected
diff --git a/gdb/testsuite/gdb.threads/pthreads.exp b/gdb/testsuite/gdb.threads/pthreads.exp
index 994846c..5c6f366 100644
--- a/gdb/testsuite/gdb.threads/pthreads.exp
+++ b/gdb/testsuite/gdb.threads/pthreads.exp
@@ -27,12 +27,6 @@ standard_testfile
 # carriage return)
 set horiz "\[^\n\r\]*"
 
-if [istarget "*-*-linux"] then {
-    set target_cflags "-D_MIT_POSIX_THREADS"
-} else {
-    set target_cflags ""
-}
-
 if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable debug] != "" } {
     return -1
 }
diff --git a/gdb/testsuite/gdb.threads/tls-nodebug.exp b/gdb/testsuite/gdb.threads/tls-nodebug.exp
index e718736..421c651 100644
--- a/gdb/testsuite/gdb.threads/tls-nodebug.exp
+++ b/gdb/testsuite/gdb.threads/tls-nodebug.exp
@@ -16,12 +16,6 @@
 
 standard_testfile
 
-if [istarget "*-*-linux"] then {
-    set target_cflags "-D_MIT_POSIX_THREADS"
-} else {
-    set target_cflags ""
-}
-
 if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable []] != "" } {
     return -1
 }
diff --git a/gdb/testsuite/gdb.threads/tls.exp b/gdb/testsuite/gdb.threads/tls.exp
index 4213178..4517688 100644
--- a/gdb/testsuite/gdb.threads/tls.exp
+++ b/gdb/testsuite/gdb.threads/tls.exp
@@ -18,12 +18,6 @@ load_lib gdb-python.exp
 
 standard_testfile tls.c tls2.c
 
-if [istarget "*-*-linux"] then {
-    set target_cflags "-D_MIT_POSIX_THREADS"
-} else {
-    set target_cflags ""
-}
-
 if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile} ${srcdir}/${subdir}/${srcfile2}" "${binfile}" executable [list c++ debug]] != "" } {
     return -1
 }
-- 
1.9.1



More information about the Gdb-patches mailing list