[pushed] Re: [RFC][08/19] Target FP: Use target format throughout expression parsing

[Yao Qi]

On 17-10-25 15:35:24, Ulrich Weigand wrote:
> > On 2017-10-09 02:12 PM, Joel Brobecker wrote:
> > > One C++ thing I did notice but forgot to report...
> > > 
> > >> +floatformat_from_string (const struct floatformat *fmt, gdb_byte *out,
> > >> +			 std::string in)
> > > 
> > > Again, to be double-checked, but I think you want to pass the argument
> > > by reference in this case. Otherwise, you may end up having an overhead
> > > with might not be necessary due to the creation of a copy of the string
> > > being passed as argument here.
> > > 
> > 
> > Indeed, it's good practice to pass constant strings (or other objects) as
> > const references (const std::string &in).
> 
> I've now pushed this patch (using the const reference as suggested).
> 

Hi Ulrich,
this patch causes a regression on arm target,

PASS -> FAIL: gdb.base/bitops.exp: print value of 0.0 || 0

https://sourceware.org/ml/gdb-testers/2017-q4/msg03040.html
Do you have any clues?

-- 
Yao (齐尧)