[PATCH, GDB] Expect prompt after no FPU warning

[Thomas Preudhomme]

Hi,

The expected output for info float when the target has no FPU does
not include the GDB prompt. This occasionally cause a test failure in
the following "finish" test when the prompt happens after the test has been
marked as PASSed, since it does not match the expected output.

This patch adds the GDB prompt to the expected output of the no FPU
regular expression.

ChangeLog entry is as follows:

*** gdb/testsuite/ChangeLog ***

2017-04-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* gdb.base/float.exp: Expect GDB prompt for targets without FPU.

Testing: test PASSes with that patch on arm-none-eabi target.

Is this ok for master branch and GDB 8 (after a 1 week period)?

Best regards,

Thomas

On 17/05/17 13:20, Thomas Preudhomme wrote:
>
>
> On 17/05/17 13:10, Yao Qi wrote:
>> Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:
>>
>>> 2017-04-27  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>>>
>>>     * gdb.base/float.exp (info float): Expect GDB prompt for ARM
>>
>> Remove " (info float)".
>>
>>>     targets without FPU.
>>>
>>
>>
>>> @@ -50,7 +50,7 @@ if { [is_aarch64_target] } then {
>>>          # if we have NEON.
>>>          pass "info float (VFP)"
>>>      }
>>> -        -re "No floating.point info available for this processor.*" {
>>> +        -re "No floating.point info available for this
>>> processor.*$gdb_prompt $" {
>>
>> The fix is right but it can be applied to all archs which may not have
>> FPU.  If you search "N floating.point info", you can find multiple hits.
>> $gdb_prompt is needed for all of them.
>
> Err yes sorry, I didn't add it because I only tested on ARM. I'll update the
> patch. Thanks!
>
> Best regards,
>
> Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nofloat_gdb_tests_expect_prompt.patch
Type: text/x-patch
Size: 2414 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20170517/deac1681/attachment.bin>