[RFA 03/10] Allow elision of some filtered frames
Pedro Alves
palves@redhat.com
Tue Jun 27 16:40:00 GMT 2017
On 04/25/2017 08:41 PM, Tom Tromey wrote:
> When a frame filter elides some frames, they are still printed by
> "bt", indented a few spaces. PR backtrace/15582 notes that it would
> be nice for users if elided frames could simply be dropped. This
> patch adds this capability.
>
So "bt elide" means "elide the elided frames", not "show me the
elided frames too". It's fine with me, though I mildly wonder whether
users will be confused by the "double negative".
> diff --git a/gdb/extension.h b/gdb/extension.h
> index 2c79411..7c35502 100644
> --- a/gdb/extension.h
> +++ b/gdb/extension.h
> @@ -100,6 +100,9 @@ enum frame_filter_flags
>
> /* Set this flag if frame locals are to be printed. */
> PRINT_LOCALS = 8,
> +
> + /* Set this flag if elided frames should not be printed. */
> + PRINT_ELIDE = 32,
Looks like 16 was elided. :-)
LGTM.
Thanks,
Pedro Alves
More information about the Gdb-patches
mailing list