[PATCH 07/25] Lazily and dynamically create i386-linux target descriptions

[Pedro Alves]

On 06/12/2017 09:41 AM, Yao Qi wrote:
> Instead of using pre-generated target descriptions, this patch
> changes GDB to lazily and dynamically create target descriptions
> according to the target hardware capability (xcr0 in i386).
> This support any combination of target features.
> 
> This patch also adds a unit test to make sure dynamically generated
> tdesc are identical to these generated from xml files.

I don't see the unit test in the patch.

Can you say something about the "regnum = %ld" change?  Is it
related to the rest of the patch?

> 
> 2017-04-27  Yao Qi  <yao.qi@linaro.org>
> 
> 	* i386-linux-tdep.c (i386_linux_read_description): Generate
> 	target description if it doesn't exist.
>         [GDB_SELF_TEST] (i386_linux_read_description_test): New unit test.
>         (_initialize_i386_linux_tdep) [GDB_SELF_TEST]: Register unit test.

Leading TAB vs spaces.

> +private:
> +  /* The register number to use for the next register we see.  */
> +  int next_regnum = 0;
>  };

"m_" prefix.

Thanks,
Pedro Alves