[PATCH 06/25] Generate c for feature instead of tdesc

Eli Zaretskii eliz@gnu.org
Tue Jun 13 14:49:00 GMT 2017


> From: Yao Qi <qiyaoltc@gmail.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 13 Jun 2017 13:07:20 +0100
> 
> >  . "The created source file can be used in GDB ..." -- used how?  I'd
> >    prefer that we said a sentence or tow about that as well, or had a
> >    cross-reference to where that is described.
> 
> The created source file is built into GDB.

Sorry, I don't understand: built into GDB how?  The GDB in which the
user runs this command can then turn around and have the produced file
built into it?

> How is the doc and NEWS entry below?

OK, with two comments, see below.

> @kindex maint print c-tdesc @r{[}@var{file}@r{]}
> @item maint print c-tdesc
> Print the target description (@pxref{Target Descriptions}) as
> a C source file.  By default, the target description is for the current
> target, but if the optional argument @var{file} is provided, that file
> is used to produce the description.  The @var{file} is an XML document,
                                                      ^^
"should be"

> of the form described in @ref{Target Description Format}.  The created
> source file is built in @value{GDBN}.
                       ^^
"into"

> > Also, what about a NEWS entry?
> 
> * The "maintenance print c-tdesc" command now takes an optional
>   argument which is the file name of XML target description.

This is OK.

Thanks.



More information about the Gdb-patches mailing list