[RFA 13/23] Replace tui_restore_gdbout with scoped_restore

[Pedro Alves]

On 05/03/2017 11:46 PM, Tom Tromey wrote:
> This patch replaces tui_restore_gdbout (a cleaup function) with a use
> of scoped_restore.  This one is broken out into its own patch because
> it might slightly change the behavior of gdb: it saves and restores
> pagination_enabled, whereas the tui_restore_gdbout unconditionally set
> pagination_enabled to 1; and I think this warrants closer review.
> 
> 2017-05-02  Tom Tromey  <tom@tromey.com>
> 
> 	* tui/tui-regs.c (tui_restore_gdbout): Remove.
> 	(tui_register_format): Use scoped_restore.

I think I ran into this in last year's console work (in an
earlier prototype.).  It just looks bogus to me to
unconditionally enable pagination.

Patch is OK.

Thanks,
Pedro Alves