[PATCH v4] gdb: ADI support

Jose E. Marchesi jose.marchesi@oracle.com
Tue Jul 25 15:31:00 GMT 2017


    
    > +/* Per-process ADI stat info.  */
    > +
    > +struct sparc64_adi_info
    > +{
    > +  /* The process identifier.  */
    > +  pid_t pid;
    > +
    > +  /* The ADI stat.  */
    > +  struct adi_stat_t stat;
    > +
    > +  /* Linked list.  */
    > +  struct sparc64_adi_info *next;
    > +};
    
    Use C++ STL list.  I suggested it on the v3 review.

General question: what's wrong with using a simple linked list of
structs if that is the developer's preference, and/or it follows the
current style of the surrounding code?  (Not saying it is in this case,
that's up to Weimin to say.)

As far as I can see the usage of STL is not mandated by the GDB coding
standards (as documented in the wiki) and developers may want to avoid
them in many circumstances.



More information about the Gdb-patches mailing list