[PATCH 01/11] Remove unused deprecated_{pre|post}_add_symbol_hook
Philipp Rudo
prudo@linux.vnet.ibm.com
Tue Feb 28 14:50:00 GMT 2017
Nobody actually uses those hooks anymore. So simply remove them.
gdb/ChangeLog
* defs.h (deprecated_pre_add_symbol_hook)
(deprecated_post_add_symbol_hook): Remove.
* symfile.c (deprecated_pre_add_symbol_hook)
(deprecated_post_add_symbol_hook): Remove.
(symbol_file_add_with_addrs): Adjust.
---
gdb/defs.h | 2 --
gdb/symfile.c | 18 ++++--------------
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/gdb/defs.h b/gdb/defs.h
index aa58605..b3086b9 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -660,8 +660,6 @@ extern char *interpreter_p;
struct target_waitstatus;
struct cmd_list_element;
-extern void (*deprecated_pre_add_symbol_hook) (const char *);
-extern void (*deprecated_post_add_symbol_hook) (void);
extern void (*selected_frame_level_changed_hook) (int);
extern int (*deprecated_ui_loop_hook) (int signo);
extern void (*deprecated_show_load_progress) (const char *section,
diff --git a/gdb/symfile.c b/gdb/symfile.c
index f2528fc..a749a2c 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -72,8 +72,6 @@ void (*deprecated_show_load_progress) (const char *section,
unsigned long section_size,
unsigned long total_sent,
unsigned long total_size);
-void (*deprecated_pre_add_symbol_hook) (const char *);
-void (*deprecated_post_add_symbol_hook) (void);
static void clear_symtab_users_cleanup (void *ignore);
@@ -1174,14 +1172,9 @@ symbol_file_add_with_addrs (bfd *abfd, const char *name,
performed, or need to read an unmapped symbol table. */
if (should_print)
{
- if (deprecated_pre_add_symbol_hook)
- deprecated_pre_add_symbol_hook (name);
- else
- {
- printf_unfiltered (_("Reading symbols from %s..."), name);
- wrap_here ("");
- gdb_flush (gdb_stdout);
- }
+ printf_unfiltered (_("Reading symbols from %s..."), name);
+ wrap_here ("");
+ gdb_flush (gdb_stdout);
}
syms_from_objfile (objfile, addrs, add_flags);
@@ -1212,10 +1205,7 @@ symbol_file_add_with_addrs (bfd *abfd, const char *name,
if (should_print)
{
- if (deprecated_post_add_symbol_hook)
- deprecated_post_add_symbol_hook ();
- else
- printf_unfiltered (_("done.\n"));
+ printf_unfiltered (_("done.\n"));
}
/* We print some messages regardless of whether 'from_tty ||
--
2.8.4
More information about the Gdb-patches
mailing list