[PATCH] PR gdb/21164: maint print {symbols,msymbols,psymbols} without args crash
Pedro Alves
palves@redhat.com
Wed Feb 15 23:06:00 GMT 2017
On 02/15/2017 10:54 PM, Sergio Durigan Junior wrote:
> On Wednesday, February 15 2017, Pedro Alves wrote:
>
>> On 02/15/2017 08:15 PM, Sergio Durigan Junior wrote:
>>
>>> This patch fixes that. OK to apply?
>>
>> Can you add some tests for this, please?
>
> How about this?
Awesome, thanks! OK with minor nits.
> commit acd6597d63b2501588318466cd308701d09a58f3
> Author: Sergio Durigan Junior <sergiodj@redhat.com>
> Date: Wed Feb 15 15:08:19 2017 -0500
> Hi,
...remove this above...
> This patch fixes that. OK to apply?
...and this "OK" from the commit log and...
> diff --git a/gdb/testsuite/gdb.base/maint.exp b/gdb/testsuite/gdb.base/maint.exp
> index 2853508..b87cbfc 100644
> --- a/gdb/testsuite/gdb.base/maint.exp
> +++ b/gdb/testsuite/gdb.base/maint.exp
> @@ -561,6 +561,14 @@ gdb_expect {
>
> #set timeout $oldtimeout
>
> +# Testing that the commands work without an argument. For this test,
Write "Test that" here.
> +# we don't need an inferior loaded/running.
> +# See PR gdb/21164.
> +gdb_exit
> +gdb_start
> +gdb_test_no_output "maint print symbols"
> +gdb_test_no_output "maint print msymbols"
> +gdb_test_no_output "maint print psymbols"
Thanks,
Pedro Alves
More information about the Gdb-patches
mailing list