[patch] DWARF-5 .debug_names DW_IDX_type_unit fix [Re: [PATCH v3.2 5/5] DWARF-5: .debug_names index consumer]

[Pedro Alves]

On 12/13/2017 10:15 PM, Pedro Alves wrote:
> On 12/13/2017 09:57 PM, Jan Kratochvil wrote:

>>> The .debug_names completely misses its support as it does not even produce
>>> DW_IDX_type_unit.
>>
>> Here you are, could you also verify my regression testing for this patch?
> 
> Thanks!  I'm testing right away.

Yep, it fixes all regressions compared to .gdb_index.

Please fix the following nits and push:

> +  int dwarf5_offset_size () const {

The '{' goes on the next line.

> +  /* A helper function that writes a single signatured_type to an
> +     debug_names.  */

Typo: "to an" => "to a".

OK with those fixed.

Thanks,
Pedro Alves