[PATCH v5 2/2] Implement pahole-like 'ptype /o' option

Sergio Durigan Junior sergiodj@redhat.com
Wed Dec 13 17:14:00 GMT 2017


On Wednesday, December 13 2017, Eli Zaretskii wrote:

>> From: Sergio Durigan Junior <sergiodj@redhat.com>
>> Cc: Tom Tromey <tom@tromey.com>, Eli Zaretskii <eliz@gnu.org>, Simon
>> Marchi <simon.marchi@ericsson.com>, Pedro Alves <palves@redhat.com>,
>> Keith Seitz <keiths@redhat.com>, Sergio Durigan Junior
>> <sergiodj@redhat.com>
>> Date: Tue, 12 Dec 2017 22:17:24 -0500
>> 
>> This commit implements the pahole-like '/o' option for 'ptype', which
>> +Issuing a @kbd{ptype /o struct tuv} would print:
>                                       ^
> Please insert "command" after the command, where I indicated.
> Otherwise the sentence reads awkward.

Done.

>> +Notice the format of the first column of comments.  There, you can
>> +find two parts separated by the @code{|} character: the @emph{offset},
>                                    ^^^^^^^^
> @samp, not @code.

Fixed.

> The documentation parts are okay with these fixed.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/



More information about the Gdb-patches mailing list