[PATCH] python: Add qualified parameter to gdb.Breakpoint
Fri Dec 8 18:27:00 GMT 2017
On 2017-12-08 09:15 AM, Eli Zaretskii wrote:
>> From: Simon Marchi <firstname.lastname@example.org>
>> CC: Simon Marchi <email@example.com>
>> Date: Thu, 7 Dec 2017 17:33:33 -0500
>> This patch adds the possibility to pass a qualified=True|False parameter
>> when creating a breakpoint in Python. It is equivalent to using
>> -qualified in a linespec. The parameter actually accepts any Python
>> value, and converts it to boolean using Python's standard rules for
>> that (https://docs.python.org/3/library/stdtypes.html#truth).
>> Unlike the -source/-line/-function/-label parameters, it is possible to
>> use -qualified with a "normal" (non-explicit) linespec. Therefore, it
>> is possible (unlike these other parameters) to use this new parameter
>> along with the spec parameter.
>> I updated the py-breakpoint.exp test. To be able to test multiple
>> locations using a namespace, I had to switch the test case to compile as
>> C++. If we really wanted to, we could run it as both C and C++, but
>> omit the C++-specific parts when running it as C.
>> * location.h (string_to_event_location): Add match_type
>> * location.c (string_to_event_location): Likewise.
>> * python/py-breakpoint.c (bppy_init): Handle qualified
>> * python.texi (Manipulating breakpoints using Python): Document
>> qualified parameter to gdb.Breakpoint.
>> * gdb.python/py-breakpoint.c (foo_ns::multiply): New function.
>> * gdb.python/py-breakpoint.exp: Compile the test case as c++,
>> call test_bkpt_qualified.
>> (test_bkpt_qualified): New proc.
> OK for the documentation part. (Do we need a NEWS entry?)
A NEWS entry would be good. I think we can complement the existing one about
-qualified instead of making a new one. What about this?
diff --git a/gdb/NEWS b/gdb/NEWS
index c6fe297..bd5ae36 100644
@@ -81,7 +81,9 @@
GDB interpret the specified function name as a complete
fully-qualified name instead. For example, using the same C++
program, the "break -q B::func" command sets a breakpoint on
- "B::func", only.
+ "B::func", only. A parameter has been added to the Python
+ gdb.Breakpoint constructor to achieve the same result when creating
+ a breakpoint from Python.
* Breakpoints on functions marked with C++ ABI tags
More information about the Gdb-patches