[PATCH] Validate explicit locations with early termination

Keith Seitz keiths@redhat.com
Thu Dec 7 23:41:00 GMT 2017


On 12/07/2017 01:33 PM, Simon Marchi wrote:
hese two commands should have elicited the same error message.
>>
>> gdb/ChangeLog:
>>
>> 	PR breakpoints/22569
>> 	* location.c (string_to_explicit_location): When terminating
>> 	parsing early, break out of enclosing loop instead of returning.
>>
>> gdb/testsuite/ChangeLog:
>>
>> 	PR breakpoints/22569
>> 	* gdb.linespec/ls-errs.exp: Change expected result of "break
>> 	-source this file has spaces.c -line 3".
>> 	Check that an explicit source file followed by whitespace is
>> 	identified as an invalid explicit location.
> 
> This is quick customer support!  This patch fixes the reported issue
> and LGTM.

I'm just happy to see someone is using the explicit location feature, and as you can see from the patch, it was pretty trivial anyway.

Thank you for the quick review, this patch has been pushed, and I will close the bug.

Keith



More information about the Gdb-patches mailing list