[PATCH v4] Add support for the readnever concept

Tom Tromey tom@tromey.com
Fri Dec 1 17:19:00 GMT 2017


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 12/01/2017 04:35 AM, Sergio Durigan Junior wrote:
>>> If readnever_symbol_files is set, then it'll have been propagated to
objfile-> flags before we get here, no?
>> 
>> Hm, I think so, yes.  I mean, assuming that objfile != NULL when we call
>> the readers, then yes; 

Pedro> Certainly you can assume that.  A reader's job is to read
Pedro> in the passed in objfile.  The very first line of elf_symfile_read
Pedro> would immediately crash otherwise, for example.

Perhaps an ATTRIBUTE_NONNULL is in order somewhere.

Tom



More information about the Gdb-patches mailing list