[PATCH v2 8/8] Python: Introduce gdb.Instruction class

Wiederhake, Tim tim.wiederhake@intel.com
Mon Apr 24 05:34:00 GMT 2017


Hi Eli!

Thank you! I've changed it locally (and the issues from your other mails as well).

Regards,
Tim

> -----Original Message-----
> From: Eli Zaretskii [mailto:eliz@gnu.org]
> Sent: Friday, April 21, 2017 2:20 PM
> To: Wiederhake, Tim <tim.wiederhake@intel.com>
> Cc: gdb-patches@sourceware.org; Metzger, Markus T
> <markus.t.metzger@intel.com>; brobecker@adacore.com; qiyaoltc@gmail.com
> Subject: Re: [PATCH v2 8/8] Python: Introduce gdb.Instruction class
> 
> > From: Tim Wiederhake <tim.wiederhake@intel.com>
> > Cc: markus.t.metzger@intel.com, brobecker@adacore.com,
> qiyaoltc@gmail.com
> > Date: Fri, 21 Apr 2017 12:49:46 +0200
> >
> > +@defvar RecordInstruction.number
> > +An integer identifying this instruction.  @var{number} corresponds to
> 
> @var is wrong here; please use @code instead.  (Yes, I know it was
> that way in theoriginal text.)
> 
> Otherwise, the documentation part is approved.
> 
> Thanks.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928



More information about the Gdb-patches mailing list