[PATCH 7/11] Add BFIN_MAX_REGISTER_SIZE
Alan Hayward
Alan.Hayward@arm.com
Fri Apr 7 16:22:00 GMT 2017
> On 7 Apr 2017, at 17:04, Yao Qi <qiyaoltc@gmail.com> wrote:
>
> Alan Hayward <Alan.Hayward@arm.com> writes:
>
>> There is some existing code in regcache.c that checks that no register in the
>> target descriptor is greater than MAX_REGISTER_SIZE.
>> Obviously, this code will vanish when MAX_REGISTER_SIZE disappears.
>>
>> If people think that this is an important check to have, then maybe there needs
>> to be an additional patch set. For each target with a FOO_MAX_REGISTER_SIZE,
>> in the init code for that target add:
>> gdb_assert (FOO_MAX_REGISTER_SIZE >= max_register_size (gdbarch));
>> ?
>
> It is not just about checking. What if the assert fail?
> FOO_MAX_REGISTER_SIZE is a strong claim for arch FOO. That is why I
> suggested "or we can define ASTAT_REGISTER_SIZE".
>
The checks would be added as a replacement for what is already in
init_regcache_descr() code in regcache.c:
for (i = 0; i < descr->nr_raw_registers; i++)
{
<snip>
gdb_assert (MAX_REGISTER_SIZE >= descr->sizeof_register[i]);
<snip>
}
If the assert fails then the its not safe for gdb to run - the define
should always be big enough to hold any register on the current architecture
Alan.
More information about the Gdb-patches
mailing list