[PATCH] Fix racy test in gdb.threads/thread-specific-bp.exp

Simon Marchi simon.marchi@polymtl.ca
Tue Apr 4 13:37:00 GMT 2017


On 2017-04-04 04:08, Yao Qi wrote:
>> Then, .* followed with [^\r\n]* doesn't seem useful, since the .* can
>> just match anything the [^\r\n]* doesn't match.
>> 
>> What about just this?
>> 
>> 	set test "continue to end"
>> 	gdb_test_multiple "$cmd" $test {
>> 	    -re "hit Breakpoint $decimal, end \\(\\) at.*$gdb_prompt " {
> 
> We should still keep \r\n before $gdb_prompt.
> 
>> 		pass $test
>> 	    }
>> 	}
> 
> The original pattern is "end .* at", so I want to leave it there, and
> change it to
> 
> 	set test "continue to end"
> 	gdb_test_multiple "$cmd" $test {
> 	    -re "Breakpoint .* end .* at .*\r\n$gdb_prompt " {
> 		pass $test
> 	    }
> 	}

LGTM.



More information about the Gdb-patches mailing list