[OBV] Remove some unnecessary code

Tom Tromey tom@tromey.com
Fri Sep 23 19:36:00 GMT 2016


This patch removes some unnecessary code.  In particular,
terminate_minimal_symbol_table is declared in minsyms.h, so it doesn't
need to be declared in objfiles.h as well.  And,
restore_ui_out_closure was rendered unnecessary by an earlier patch,
so the structure definition can be removed now.

I'm checking this in as obvious.

Tested by rebuilding on x86-64 Fedora 24 with --enable-targets=all;
which would notice any missing includes of minsyms.h.

2016-09-23  Tom Tromey  <tom@tromey.com>

	* utils.c (struct restore_ui_out_closure): Remove.
	* objfiles.h (terminate_minimal_symbol_table): Don't declare.
---
 gdb/ChangeLog  | 5 +++++
 gdb/objfiles.h | 2 --
 gdb/utils.c    | 6 ------
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ce63f93..fe3ea42 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-09-23  Tom Tromey  <tom@tromey.com>
+
+	* utils.c (struct restore_ui_out_closure): Remove.
+	* objfiles.h (terminate_minimal_symbol_table): Don't declare.
+
 2016-09-23  Yao Qi  <yao.qi@linaro.org>
 
 	* nat/linux-osdata.c (linux_xfer_osdata_threads): Replace
diff --git a/gdb/objfiles.h b/gdb/objfiles.h
index 59b73f1..87a974c 100644
--- a/gdb/objfiles.h
+++ b/gdb/objfiles.h
@@ -501,8 +501,6 @@ extern CORE_ADDR entry_point_address (void);
 
 extern void build_objfile_section_table (struct objfile *);
 
-extern void terminate_minimal_symbol_table (struct objfile *objfile);
-
 extern struct objfile *objfile_separate_debug_iterate (const struct objfile *,
                                                        const struct objfile *);
 
diff --git a/gdb/utils.c b/gdb/utils.c
index 2afff80..5bb0b67 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -332,12 +332,6 @@ make_cleanup_htab_delete (htab_t htab)
   return make_cleanup (do_htab_delete_cleanup, htab);
 }
 
-struct restore_ui_out_closure
-{
-  struct ui_out **variable;
-  struct ui_out *value;
-};
-
 struct restore_ui_file_closure
 {
   struct ui_file **variable;
-- 
2.7.4



More information about the Gdb-patches mailing list