[PATCH v2 05/31] 'struct expression *' -> gdb::unique_xmalloc_ptr<expression>

Pedro Alves palves@redhat.com
Wed Oct 19 22:36:00 GMT 2016


On 10/19/2016 11:25 PM, Simon Marchi wrote:
> On 2016-10-19 17:50, Pedro Alves wrote:
>>> I did a quick grep for various converted struct names allocation
>>> keywords, I see there is still a
>>>
>>>     bp_location = XNEWVEC (struct bp_location *, bp_location_count);
>>>
>>> Does that need to be converted too?
>>
>> You mean converted to "new"?  No, because that is an array
>> of pointers, not array of bp_location objects.
> 
> Oh right I missed that, sorry.

No worries.  Thanks much for double-checking for missing
conversions like this, and for reviewing the patch in the
first place.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list