[PATCH] Fix -trace-save crash when argument is missing

Simon Marchi simon.marchi@ericsson.com
Mon Oct 17 20:56:00 GMT 2016


On 16-10-17 04:49 PM, Simon Marchi wrote:
> Pushed.  Here is the final version:

...

Oops, I had forgotten to update a comment.  I pushed this quick fix:

>From 3ccdb4324b0dc9fa46ee7cad9b370f8c7c370c3b Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon, 17 Oct 2016 16:54:24 -0400
Subject: [PATCH] Fix comment in mi-trace-save.exp

This fixes a comment I forgot to update in the previous patch.

gdb/testsuite/ChangeLog:

	* gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args):
	Update comment.
---
 gdb/testsuite/ChangeLog                   | 5 +++++
 gdb/testsuite/gdb.trace/mi-trace-save.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index f0c8415..9d35283 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
 2016-10-17  Simon Marchi  <simon.marchi@ericsson.com>

+	* gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args):
+	Update comment.
+
+2016-10-17  Simon Marchi  <simon.marchi@ericsson.com>
+
 	* gdb.trace/mi-trace-save.exp: New file.

 2016-10-13  Yao Qi  <yao.qi@linaro.org>
diff --git a/gdb/testsuite/gdb.trace/mi-trace-save.exp b/gdb/testsuite/gdb.trace/mi-trace-save.exp
index 96bb70d..edb3a59 100644
--- a/gdb/testsuite/gdb.trace/mi-trace-save.exp
+++ b/gdb/testsuite/gdb.trace/mi-trace-save.exp
@@ -21,7 +21,7 @@ load_lib mi-support.exp

 mi_gdb_start

-# Test without the required "filename" argument.
+# Test with the wrong number of arguments.

 proc test_trace_save_wrong_num_args { } {
     set err_re [string_to_regexp "^error,msg=\"Exactly one argument required (file in which to save trace data)\""]
-- 
2.10.1




More information about the Gdb-patches mailing list