[patch+7.12.1 1/2] Code cleanup: write_exp_msymbol: +is_tls

[Jan Kratochvil]

On Tue, 11 Oct 2016 16:21:58 +0200, Yao Qi wrote:
> On Sun, Oct 9, 2016 at 7:56 PM, Jan Kratochvil
> <jan.kratochvil@redhat.com> wrote:
> > --- a/gdb/parse.c
> > +++ b/gdb/parse.c
> >
> >    /* The minimal symbol might point to a function descriptor;
> >       resolve it to the actual code address instead.  */
> >    pc = gdbarch_convert_from_func_ptr_addr (gdbarch, addr, &current_target);
> > -  if (pc != addr)
> > +  if (!is_tls && pc != addr)
> 
> It does have functionality change.

Ah, you are right.


> This should be moved to patch #2?

It is unrelated to patch #2, it could be a new patch #3 (or patch #1.5).
In fact if (tls) then gdbarch_convert_from_func_ptr_addr should not be even
called so this patch is also wrong (suboptimal).

Let's forget about this patch hunk now.


Jan