[RFA 06/22] Introduce scoped_minimal_symbol_reader

Pedro Alves palves@redhat.com
Mon Oct 10 23:26:00 GMT 2016


On 10/11/2016 12:06 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> GCC eschews using // comments, to avoid ending up with a mixbag
> Pedro> of styles.  Maybe we should follow suit?
> 
> I don't remember - did you want me to change this or not?
> I prefer "//" comments but it's up to you.

I'd prefer to change it for the sake of consistency.  A single comment
in a different style in between other comments stands out as odd to me.

For tail-end single-line comments, like

  } // namespace gdb

it doesn't look that odd to me.  AFAICS, these are the cases
where gcc uses // too, for the most part.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list