[RFA 06/22] Introduce scoped_minimal_symbol_reader

Tom Tromey tom@tromey.com
Mon Oct 10 23:06:00 GMT 2016


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> GCC eschews using // comments, to avoid ending up with a mixbag
Pedro> of styles.  Maybe we should follow suit?

I don't remember - did you want me to change this or not?
I prefer "//" comments but it's up to you.

>> +class scoped_minimal_symbol_reader

Pedro> Seems like this is growing to be _the_ reader in following patches?
Pedro> I'm wondering whether the "scoped_" prefix will make sense going
Pedro> forward.

I made this change.  Thank goodness for git filter-branch.

Tom



More information about the Gdb-patches mailing list