[RFA 15/22] Use std::string in macho_symfile_read_all_oso

Tom Tromey tom@tromey.com
Mon Oct 10 22:40:00 GMT 2016


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> +              if (strncmp (oso2->name, archive_name.c_str (), pfx_len) != 0)

Pedro> Since archive_name is now a std::string, we can use ==/!= for string
Pedro> comparison:
Pedro>               if (archive_name != oso2->name)

It isn't entirely clear to me that this is valid, given that the current
comparison is using strncmp.

Tom



More information about the Gdb-patches mailing list