[ob/pushed+7.11 1/2] Remove gdb/python/python.c code that handles strlen failing with -1

Pedro Alves palves@redhat.com
Tue May 3 11:22:00 GMT 2016


This makes no sense -- strlen doesn't really ever fail with -1.

gdb/ChangeLog:
2016-05-03  Pedro Alves <palves@redhat.com>

	* python/python.c (_initialize_python) [IS_PY3K]: Remove dead
	code.
---
 gdb/ChangeLog       | 5 +++++
 gdb/python/python.c | 5 -----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 05e5c40..c5b7325 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-05-03  Pedro Alves <palves@redhat.com>
+
+	* python/python.c (_initialize_python) [IS_PY3K]: Remove dead
+	code.
+
 2016-05-03  Pedro Alves  <palves@redhat.com>
 
 	* configure.ac (PYTHON_LIBS): Sed away "-Xlinker -export-dynamic".
diff --git a/gdb/python/python.c b/gdb/python/python.c
index b90e5e5..ea9cf85 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -1711,11 +1711,6 @@ message == an error message without a stack will be printed."),
   oldloc = setlocale (LC_ALL, NULL);
   setlocale (LC_ALL, "");
   progsize = strlen (progname);
-  if (progsize == (size_t) -1)
-    {
-      fprintf (stderr, "Could not convert python path to string\n");
-      return;
-    }
   progname_copy = (wchar_t *) PyMem_Malloc ((progsize + 1) * sizeof (wchar_t));
   if (!progname_copy)
     {
-- 
2.5.5



More information about the Gdb-patches mailing list