[PATCH] Simplify gdb.reverse/until-reverse.c

Pedro Alves palves@redhat.com
Tue Mar 29 16:46:00 GMT 2016


On 03/29/2016 02:17 PM, Yao Qi wrote:
> Nowadays, functions fprintf, printf and malloc are executed in
> gdb.reverse/until-reverse.c, so that it takes much time to record
> instructions inside them.  This may cause timeout, and we had several
> fixes to bump the timeout,
>
>   https://sourceware.org/ml/gdb-patches/2012-02/msg00038.html
>   https://sourceware.org/ml/gdb-patches/2015-08/msg00186.html

> however, I can't figure out how these functions (fprintf, printf and
> malloc) are related to the test itself.  marker1 is a function from
> shared library too so we don't need these complicated libc functions
> at all.  IMO, recording the instructions in these libc functions has
> nothing to do with the test itself except slow down the test.  This
> patch is to remove the usage of fprintf and printf, and also move
> malloc to a dead code path.

This is fine with me.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list