Commit: AArch64: Simulate scalar NEG and vector MUL

[Nick Clifton]

Hi Mike,

>> +#define GET_VEC_ELEMENT(REG, ELEMENT, FIELD)	   \
> is using all caps for arg names a normal style thing ?

For macros, yes.

For example, in gdb/gdbarch.h:

#define GDBARCH_OBSTACK_CALLOC(GDBARCH, NR, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), (NR) * sizeof (TYPE)))


>> +      if (element > ARRAY_SIZE (cpu->fr[0].FIELD)) \
> shouldn't this be ELEMENT ?  and be >= ?

Yes.

>> +      if (ELEMENT > ARRAY_SIZE (cpu->fr[0].FIELD))			\

Yup.  Patch coming.

Cheers
  Nick