[PATCH 3/5, doc RFA]: Enhancements to "flags": main patch

Doug Evans dje@google.com
Thu Mar 3 18:46:00 GMT 2016


Eli Zaretskii writes:
  > > Date: Mon, 29 Feb 2016 23:07:09 +0000
  > > From: Doug Evans <dje@google.com>
  > > Cc: cole945@gmail.com
  > >
  > >   @cindex <struct>
  > > +@cindex <flags>
  > >   If a register's value is composed from several separate values,  
define
  > > -it with a structure type.  There are two forms of the @samp{<struct>}
  > > -element; a @samp{<struct>} element must either contain only bitfields
  > > -or contain no bitfields.  If the structure contains only bitfields,
  > > -its total size in bytes must be specified, each bitfield must have an
  > > -explicit start and end, and bitfields are automatically assigned an
  > > -integer type.  The field's @var{start} should be less than or
  > > -equal to its @var{end}, and zero represents the least significant bit.
  > > +it with either a structure type or a flags type.
  > > +A flags type may only contain bitfields.
  > > +A structure type may either contain only bitfields or contain no  
bitfields.
  > > +If the value contains only bitfields, its total size in bytes must be
  > > +specified.
  >
  > This drops some of the previous description.  Is it no longer correct?

The text has moved and been reorganized a bit, that's all.

  > > +Enum target types are useful in @samp{struct} and @samp{flags}
  > > +register descriptions. @xref{Target Description Format}.
  >                         ^^
  > Two spaces here, please.
  >
  > Otherwise, the documentation part is OK, thanks.



More information about the Gdb-patches mailing list