[RFA 3/6] Comment out some unused overlay code

Yao Qi qiyaoltc@gmail.com
Tue Jun 28 14:36:00 GMT 2016


On Mon, Jun 6, 2016 at 10:33 PM, Tom Tromey <tom@tromey.com> wrote:
> This patch comments out some unneeded initializations in overlay code
> in symfile.c.  Normally I would not comment out code like this, but
> the uses of "size" in these functions are commented out.  If you'd
> prefer I could just delete the comments.

I am inclined to remove these commented-out statements.

These statements were commented out in 1998, and nobody wanted to add
them back again since then,

Fri Jan 23 07:47:06 1998  Fred Fish  <fnf@cygnus.com>

        * config/d10v/tm-d10v.h (CALL_DUMMY): Define as "{ 0 }".
        (TARGET_READ_FP): Define to d10v_read_fp rather than d10v_read_sp.
        (TARGET_WRITE_FP): Define to d10v_write_fp rather than d10v_write_sp.
        (d10v_write_fp, d10v_read_fp): Add prototypes.
        * symtab.c (decode_line_1): Remove assignment of sals[0].pc field.
        * symfile.c (simple_overlay_update, simple_overlay_update_1):
        Ignore the size of overlay sections.  This check is redundant anyway.

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list