[PATCH 3/6] Fetch the ELF auxiliary vector from live processes on FreeBSD.

Pedro Alves palves@redhat.com
Mon Jun 20 23:01:00 GMT 2016


On 06/16/2016 07:01 AM, John Baldwin wrote:

> +static enum target_xfer_status
> +fbsd_xfer_partial (struct target_ops *ops, enum target_object object,

"Implement foo"-style intro comment missing.

> +  switch (object)
> +    {
> +    case TARGET_OBJECT_AUXV:
> +      {
> +	struct cleanup *cleanup = make_cleanup (null_cleanup, NULL);
> +	unsigned char *buf;
> +	size_t buflen;
> +	int mib[4];
> +
> +	if (writebuf)

writebuf != NULL.

Otherwise LGTM.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list