[PATCH] Add method/format information to =record-started
Simon Marchi
simon.marchi@ericsson.com
Mon Jun 6 13:39:00 GMT 2016
On 16-06-06 09:20 AM, Metzger, Markus T wrote:
> Looks good except that BTRACE_FORMAT_NONE is not handled in the switch.
>
> We could leave it as a bad format string to be detected by the MI consumer. This would
> leave the short and long versions of btrace_format_string symmetric.
What do you mean by MI consumer? The MI front-end (e.g. Eclipse), or the MI interpreter
code in gdb (mi-interp.c) ?
My thought was that not handling it in the switch (and let gdb implode) would help catch
a bug earlier, compared to emitting some invalid string. But I don't really mind. I can
add
case BTRACE_FORMAT_NONE:
return "unknown";
More information about the Gdb-patches
mailing list