[PATCH] infcmd, btrace: fix crash in 'finish' for tailcall-only frames

Yao Qi qiyaoltc@gmail.com
Wed Jun 1 08:51:00 GMT 2016


Markus Metzger <markus.t.metzger@intel.com> writes:

Patch is good to me, nits on code format,

> +  do {

"{" should be in the new line.

> +    start = frame;
> +
> +    frame = skip_tailcall_frames (frame);
> +    if (frame == NULL)
> +      break;
> +
> +    frame = skip_unwritable_frames (frame);
> +    if (frame == NULL)
> +      break;
> +  } while (start != frame);

"while" should be in the new line too.  The format is documented in
https://www.gnu.org/prep/standards/standards.html#Writing-C

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list