[PATCH 3/4] Plumb enum remove_bp_reason all the way to target_remove_breakpoint

[Yao Qi]

Pedro Alves <palves@redhat.com> writes:

Hi Pedro,

> So the target knows whether we're detaching breakpoints.
> Nothing uses the parameter in this patch yet.
>
> gdb/ChangeLog:
> 2016-02-14  Pedro Alves  <palves@redhat.com>
>
> 	* break-catch-sig.c (signal_catchpoint_remove_location): Adjust
> 	interface.
> 	* break-catch-syscall.c (remove_catch_syscall):
> 	* breakpoint.c (enum remove_bp_reason): Moved to breakpoint.h.
> 	(remove_breakpoint_1): Pass 'reason' down.
> 	(remove_catch_fork, remove_catch_vfork, remove_catch_solib)
> 	(remove_catch_exec, remove_watchpoint, remove_masked_watchpoint)
> 	(base_breakpoint_remove_location, bkpt_remove_location)
> 	(bkpt_probe_remove_location, bkpt_probe_remove_location): Adjust
> 	interface.
> 	* breakpoint.h (enum remove_bp_reason): Moved here from
> 	breakpoint.c.
> 	(struct breakpoint_ops) <remove_location>: Add 'reason' parameter.
> 	* corelow.c (core_remove_breakpoint): New function.
> 	(init_core_ops): Install it as to_remove_breakpoint method.
> 	* exec.c (exec_remove_breakpoint): New function.
> 	(init_exec_ops): Install it as to_remove_breakpoint method.
> 	* mem-break.c (memory_remove_breakpoint): Adjust interface.
> 	* record-btrace.c (record_btrace_remove_breakpoint): Adjust
> 	interface.
> 	* record-full.c (record_full_remove_breakpoint)
> 	(record_full_core_remove_breakpoint): Adjust interface.
> 	* remote.c (remote_remove_breakpoint): Adjust interface.
> 	* target-debug.h (target_debug_print_enum_remove_bp_reason): New
> 	macro.
> 	* target-delegates.c: Regenerate.
> 	* target.c (target_remove_breakpoint): Add 'reason' parameter.
> 	* target.h (struct target_ops) <to_remove_breakpoint>: Add
> 	'reason' parameter.
> 	(target_remove_breakpoint, memory_remove_breakpoint): Add 'reason'
> 	parameter.

We also need to add 'reason' in m32r_remove_breakpoint,
mips_remove_breakpoint and procfs_remove_breakpoint, otherwise the patch
breaks the all-targets build.

This patch series look good to me.

-- 
Yao (齐尧)