[PATCH 0/3] Minor refactorings in arm-tdep.c instruction decoding

Simon Marchi simon.marchi@ericsson.com
Wed Feb 10 16:17:00 GMT 2016


I am currently working on extracting the instruction decoding from the
displaced stepping support in arm-tdep.c, in order to share the functionality
with the upcoming fast tracepoint support.  I did a few refactors that helped
me correlate the code with the ARM Architecture Reference Manual.  I think the
change helps readability in general, and especially when you have the manual
open on the side.

The idea is to follow the the order of the manual, use the same names and do
the same "checks" (avoid using unnecessary shortcuts that make the code more
cryptic).

Simon Marchi (3):
  arm-tdep.c: Refactor arm_process_displaced_insn
  arm-tdep.c: Refactor arm_decode_dp_misc
  arm-tdep.c: Refactor arm_decode_media

 gdb/arm-tdep.c | 171 ++++++++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 121 insertions(+), 50 deletions(-)

-- 
2.5.1



More information about the Gdb-patches mailing list