[PATCH] btrace: add unsupported/untested messages when skipping tests

Metzger, Markus T markus.t.metzger@intel.com
Mon Dec 12 08:26:00 GMT 2016


> -----Original Message-----
> From: Luis Machado [mailto:lgustavo@codesourcery.com]
> Sent: Friday, December 9, 2016 4:32 PM
> To: Metzger, Markus T <markus.t.metzger@intel.com>; gdb-
> patches@sourceware.org
> Subject: Re: [PATCH] btrace: add unsupported/untested messages when skipping
> tests

Hi Luis,


> In previous reviews it was deemed more appropriate to just say "failed
> to compile", since the source file information could be extracted from
> the testcase itself via the log file.

I don't see why we should not print it.  The file name may already help to see a
pattern just from the FAIL messages.  Further, if a test is compiling more than one
file, we'd want to see which compilation failed.

Do you have a link where this was discussed?

Thanks,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928



More information about the Gdb-patches mailing list