[PATCH] Bug 20936 - provide sparc and sparcv9 target description XML files

Ivo Raisr ivo.raisr@oracle.com
Tue Dec 6 23:46:00 GMT 2016

On 6.12.2016 15:26, Yao Qi wrote:

> On 16-12-06 11:40:42, Ivo Raisr wrote:
>> Please find attached a patch which fixes PR tdep/20936.
> Hi Ivo,
> Could you add a new directory "sparc" in gdb/features/ and put all
> .xml files there?

Hi Yao,
Thank you for looking into my patch.
New directory created.

> I suppose your next patch is to change sparc{64}-tdep.c to use these
> target descriptions.  I'd like to get target description definition
> and use in a single patch.  You add some thing new in this patch,
> but it is not used at all.

Done. See the attached patch.

> All these new added features should be documented
> https://sourceware.org/gdb/current/onlinedocs/gdb/Standard-Target-Features.html

I updated gdb.texinfo with a new subsection for sparc targets.

The rest of your comments have been also addressed.
New ChangeLog entry is attached, to avoid problems with email client
replacing tabs with spaces.

Kind regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sparc_tdesc.patch
Type: text/x-patch
Size: 52359 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20161206/81bd67a2/attachment.bin>
-------------- next part --------------
ChangeLog entry:
2016-12-07  Ivo Raisr  <ivo.raisr@oracle.com>

	PR tdep/20936
	Provide and use sparc32 and sparc64 target description XML files.
	* sparc32-cp0.xml, sparc32-cpu.xml, sparc32-fpu.xml: New files for
	sparc 32-bit.
	* sparc64-cp0.xml, sparc64-cpu.xml, sparc64-fpu.xml: New files
	for sparc 64-bit.
	* sparc32-solaris.xml, sparc64-solaris.xml: New files for sparc32
	and sparc64 on Solaris.
	* sparc-solaris.c, sparc64-solaris.c: Generated.
	* sparc-tdep.h: Deal with sparc32 and sparc64 differences
	in target descriptions. Separate real and pseudo registers.
	* sparc-tdep.c: Validate and use registers of the target description.
	Pseudo registers are numbered after all real registers from the target
	description; deal with it.
	* sparc64-tdep.h: Separate real and pseudo registers.
	* sparc64-tdep.c: Pseudo registers are numbered after all real
	registers from the target description; deal with it.
	* gdb.texinfo: New node "Sparc Features".

More information about the Gdb-patches mailing list