[PATCH 1/2 v2] Add unit test to aarch64 prologue analyzer

Pedro Alves palves@redhat.com
Thu Dec 1 12:57:00 GMT 2016


On 12/01/2016 11:16 AM, Yao Qi wrote:

> +#if GDB_SELF_TEST
> +
> +namespace selftests
> +{
> +
> +  /* Instruction reader from manually cooked instruction sequences.  */
> +
> +  class instruction_reader_test : public abstract_instruction_reader
> +  {

This whole class should be indented at column 0.

> +  public:
> +    template<size_t SIZE>
> +    instruction_reader_test (const uint32_t (&insns)[SIZE])
> +      : m_insns (insns), m_insns_size (SIZE)
> +    {}

Please add "explicit".  Sorry that I missed adding it myself.

Otherwise LGTM.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list