[PATCH 2/2] Replace address and aspace with thread in struct step_over_info

Yao Qi qiyaoltc@gmail.com
Tue Apr 19 13:55:00 GMT 2016


Pedro Alves <palves@redhat.com> writes:

> I think this is problematic.
>
> While a thread is being stepped past a breakpoint, it's possible that the
> user sets some other breakpoint, and then we end up in
> stepping_past_instruction_at
> deciding whether we can insert that new breakpoint, while the step-over thread
> is running.
>
> As soon as the step-over thread is resumed for the actual step-over, it's
> regcache is flushed (target_resume -> registers_changed_ptid).  From that point
> and until the thread stops again, trying to fetch its regcache will error out,
> because you can't read registers from a thread that is running.

OK, that is a good case.  I didn't think of it.  I withdraw the patch.

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list