[PATCH 4/4] Fix solib-display.exp remote check

Pedro Alves palves@redhat.com
Mon Apr 11 18:27:00 GMT 2016


On 04/06/2016 04:15 AM, Simon Marchi wrote:

> The test uses "run"

Does it have to?  Can't we use "kill" followed by runto_main
again, instead of gdb_start_cmd ?

Why did you move the check to within the loop?  I thought one
could check [target_info exists use_gdb_stub] at the top?
I'd find the patch OK with that.  It'd be nicer to avoid
gdb_start_cmd in the first place, but use_gdb_stub is still
an improvement.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list