[PATCH 3/4] Fix detach.exp remote check

Pedro Alves palves@redhat.com
Mon Apr 11 18:16:00 GMT 2016


On 04/06/2016 04:15 AM, Simon Marchi wrote:
> This test seems to work with both native-gdbserver and
> native-extended-gdbserver, so I removed the remote check.
> 
> When running with native-gdbserver (a stub-like target), detach makes
> gdbserver stop and gdb disconnect.  runto_main just spawns a brand new
> gdbserver.  So it tests the exact same thing twice.  It doesn't hurt
> though.

It's not exactly the same thing, as the second test runs with the same
gdb, so it exercises "run" or "target connect" after a previous
"detach", which can expose problems with stale state from the previous
connection.  So also useful.

> gdb/testsuite/ChangeLog:
> 
> 	* gdb.base/detach.exp: Remove is_remote check.

OK.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list