[PATCH] value: Make accessor methods' parameters const-correct

Martin Galvan martin.galvan@tallertechnologies.com
Thu Apr 7 13:50:00 GMT 2016


On Thu, Apr 7, 2016 at 10:38 AM, Simon Marchi <simon.marchi@ericsson.com> wrote:
> And to be pedantic, if you want to make all arguments const you should also do this :)
>
> -set_value_bitpos (struct value *value, int bit)
> +set_value_bitpos (struct value *const value, const int bit)

Yeah, I thought of that but it'd been too much. Thanks for the
feedback guys, I'll be sending v2 in a moment.

Btw, while I was looking through value.c I saw many functions whose
names are 'deprecated', or 'hack', yet they're still being used. If
you guys want I can look into removing/replacing them after I'm done
with the synthetic reference fixes.



More information about the Gdb-patches mailing list