[patch, testsuite] require readline for gdb.linespec/explicit.exp tab-completion tests

Sandra Loosemore sandra@codesourcery.com
Fri Sep 18 15:56:00 GMT 2015


On 09/17/2015 10:30 PM, Doug Evans wrote:
> Keith Seitz <keiths@redhat.com> writes:
>> On 09/17/2015 12:28 AM, Sandra Loosemore wrote:
>>> Tab-completion tests require readline support.  The ones in
>>> gdb.base/completion.exp are already conditional, but the recently-added
>>> gdb.linespec/explicit.exp tests are not.  This patch fixes that, and
>>> also an obvious typo ("faill" -> "fail").  The patch is kind of long
>>> because I had to insert an "if" block and reindent, but there's nothing
>>> else going on here.  OK to commit?
>>
>> I'm not a maintainer, but I wouldn't hesitate to commit this as obvious.
>> Thank you for catching (and fixing) that.
>
> Agreed.

OK, since this seems "obvious" and uncontroversial I've gone ahead and 
pushed this patch to get it out of my pile.

-Sandra



More information about the Gdb-patches mailing list