[PATCH 2/8] [AArch64] Move instruction decoding into new arch/ directory

Yao Qi qiyaoltc@gmail.com
Tue Sep 15 10:10:00 GMT 2015


Pierre Langlois <pierre.langlois@arm.com> writes:

> diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv
> index aa232f8..d263381 100644
> --- a/gdb/gdbserver/configure.srv
> +++ b/gdb/gdbserver/configure.srv
> @@ -50,7 +50,7 @@ case "${target}" in
>    aarch64*-*-linux*)
>  			srv_regobj="aarch64.o"
>  			srv_regobj="${srv_regobj} arm-with-neon.o"
> -			srv_tgtobj="linux-aarch64-low.o aarch64-linux-hw-point.o"
> +			srv_tgtobj="linux-aarch64-low.o aarch64-linux-hw-point.o aarch64-insn.o"

This line is too lone.  Please shorten it like what are doing below.

>  			srv_tgtobj="$srv_tgtobj linux-aarch32-low.o"
>  			srv_tgtobj="$srv_tgtobj aarch64-linux.o"
>  			srv_tgtobj="${srv_tgtobj} $srv_linux_obj"

Otherwise, that patch is OK.

-- 
Yao (齐尧)



More information about the Gdb-patches mailing list