[PATCH V2] PR varobj/18564 regression in showing __thread so extern variable

Sergio Durigan Junior sergiodj@redhat.com
Thu Sep 10 20:17:00 GMT 2015


On Thursday, September 10 2015, I wrote:

> On Thursday, September 03 2015, Philippe Waroquiers wrote:
>
>> On Thu, 2015-09-03 at 10:37 +0100, Yao Qi wrote:
>>> We don't have to get printf involved in the test, because some targets
>>> may don't have printf at all.
>> Ok, effectively, without printf, the test will then run on these
>> targets.
>>
>> Find below the new version of the patch.
>> All your comments should be handled.
>>
>> The fix itself still need to be reviewed.
>>
>> Thanks for your review
>>
>> Any comment on the fix ? Ok to commit ?
>
> Thanks, Philippe.
>
> I wanted to reply to this earlier, sorry.  I looked at your proposed
> patch, and it looks fine for me.  It makes sense, and is "simple" enough
> that nothing seemed out of place.
>
> I am not a maintainer for this part of the code, but I think it can be
> safely approved.

And now I saw that Pedro already approved the patch.  Well, sorry about
the delay, again.

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/



More information about the Gdb-patches mailing list